Maru Berezin

variable-length arrays are not recommended: not all compilers support VLA, VLAs increase size of code, see https://lkml.org/lkml/2018/3/7/621

Must not include additional headers in MHD main header (except system headers), must not add new MHD headers to be included by client applications.

notify_completed() should be called when the stream is destroyed, but only after the bytes are sent?

Improve performance

1

Use `http2_benchmark.c` to compare with HTTP/1.

https://github.com/maru/libmicrohttpd-http2/blob/5f834d75a866dbfff598039c8e5da730709d2798/src/microhttpd/connection_http2.c#L675-L682

https://github.com/maru/libmicrohttpd-http2/blob/5f834d75a866dbfff598039c8e5da730709d2798/src/microhttpd/connection_http2.c#L1761-L1771

Timeout causes multiple calls to MHD_connection_handle_idle

1

When a connection timeout occurs (in normal_timeout_tail), MHD_connection_handle_idle is called, but the connection termination is not executed because in this condition: https://github.com/maru/libmicrohttpd-http2/blob/e7dcdeb5b48197610aff8c65c0336a8c55f63892/src/microhttpd/connection.c#L3720-L3721 timeout is equal to `(MHD_monotonic_sec_counter() - connection->last_activity)`. However,...

Audit functions like `MHD_parse_arguments_`, `MHD_http_unescape`: https://github.com/maru/libmicrohttpd-http2/blob/ace60e23531d15ed1a7e2e235388d33a6da468ba/src/microhttpd/internal.c#L136

Terminate session with error NGHTTP2_SETTINGS_TIMEOUT if settings were not received after a period of time.