node-irc icon indicating copy to clipboard operation
node-irc copied to clipboard

Published 20 hours ago • verified publisher icon martynsmith

Fix user modes updating

Open zephrax opened this issue 8 years ago • 2 comments

The user modes inside "channel.users" structure was not being updated. The comparison wasn't returning the expected value, so I changed it a little. Now the user modes are being updated successfuly.

zephrax avatar Nov 02 '15 00:11 zephrax

I'm not too fond of if (typeof channel.users[user] !== 'undefined') these kinds of checks, false is not undefined but it doesn't hold and value to be replaced either.

checking for its length, though, does seem safe enough: if it has length, it has things inside.

moshmage avatar Nov 05 '15 16:11 moshmage

This was rewritten in PR #351 and now functions correctly as far as I can tell.

ward avatar Mar 28 '16 10:03 ward