node-irc icon indicating copy to clipboard operation
node-irc copied to clipboard

Add regexp for Japanese and Korean nicknames.

Open leeopop opened this issue 10 years ago • 3 comments

Some IRC servers support unicode, and even for nicknames. The message handler receives an 'undefined' sender name if its name contains unicode characters.

I tried to add all non-special unicode characters, but I couldn't find any better ways than adding character range manually.

Also, I wander why there is a trailing '-' inside the [] block. Isn't '-' implies character ranges?

Sorry for some incomplete opinions. (This is my first time doing with js:)

leeopop avatar Sep 15 '15 16:09 leeopop

And as per the RFC Nicknames can't start with numbers, only letters or special chars [which I'm not certain of which]
nickname = ( letter / special ) *8( letter / digit / special / "-" )
@leeopop turns out that "missing" dash is on the rfc ;)

moshmage avatar Sep 30 '15 22:09 moshmage

+1 For this PR. If current IRC spec does not support CJK nicknames, why don't we at least opt-in this feature?

simnalamburt avatar Mar 25 '16 19:03 simnalamburt

+1 for this PR.

Corea avatar Mar 21 '17 12:03 Corea