Andrey Martyanov

Results 24 comments of Andrey Martyanov

Any chance it will be merged soon?

I prefer the library to be as low-level as possible, it's easy to write high-level API over low-level one, but the opposite is not true. For example, another asynchronous `RabbitMQ`...

Hey @generall, many thanks! Got it, I will sketch the machinery and return with something usable.

Thanks! I planned to wrap the rpc enums in custom enum types, like one from watch commands.

Please see https://github.com/martyanov/aetcd/blob/master/aetcd/rtypes.py#L257 for example. I personally don't like the string literals here, pretty much easy to abuse.

Why not just `SortOrder` and `SortTarget` as names for the enums? Not sure if I like the `_CaseInsensitiveStringEnum`, I prefer to be more strict and explicit. :) Breaking the API...

A little follow up. If you make the enums importable via `aetcd`, as all other `rtypes` types, then it's just a `aetcd.SortTarget.KEY`. Personally I'm fine with this.

Yep, but only the enums should be explicitly imported, as other types return implicitly as operation results, so they only needed may be for type annotations. I think the short...

@cend-gh thanks for the report! What do you suggest?