Martín Triay

Results 103 comments of Martín Triay

> Write all non-H1 headings in sentence case (only capitalize the first word and proper nouns) > > * For the record, I disagree with this approach. I instead vote...

to do: resolve [whether we include return values in API definitions](https://github.com/OpenZeppelin/cairo-contracts/pull/689#discussion_r1322310941)

Opened the "Consider documenting asserts/guards" discussion separately in its own thread: #745

to do: decide what to do regarding duplicating function definitions between interface, component, and function definitions in API docs: see discussions [#1](https://github.com/OpenZeppelin/cairo-contracts/pull/863#discussion_r1505263064), [#2](https://github.com/OpenZeppelin/cairo-contracts/pull/920#discussion_r1508373452), and [#3](https://github.com/OpenZeppelin/cairo-contracts/pull/920#discussion_r1508124125)

Hi. Sorry for the long wait, this fell through the cracks. I could not reproduce this, is the problem persisting?

> * We still need to define the API to expose both Cairo1 and Cairo0 compilers in the transition period (with starknet 0.11). Do we? I'm assuming there will be...

Heh i've been fighting that spacing a lot, not easy. Not sure if small issue but i'd remove either the declarations file altogether.

Closing this since it will not be relevant anymore after the ongoing Cairo 1.0 migration. If you think this is a mistake, feel free to open a new issue.

Closing this since it will not be relevant anymore after the ongoing Cairo 1.0 migration. If you think this is a mistake, feel free to open a new issue.

Closing this since it will not be relevant anymore after the ongoing Cairo 1.0 migration. If you think this is a mistake, feel free to open a new issue.