museeks icon indicating copy to clipboard operation
museeks copied to clipboard

Remember tracks list scroll position when switching views

Open ldexterldesign opened this issue 4 years ago • 8 comments

Hi!

Hope you're well

Thanks for wonderful software

As a user, when I switch/tab between Library, Playlist and Setting views, I want states to persist instead of defaulting to the top of the view (i.e. first track in list) so I don't have to scroll back to my previous state (e.g. a track half way down my list)

Steps to reproduce issue

  1. Click (i.e. play) a track in Library, preferably something one had to scroll the view to find
  2. Navigate to another view (e.g. Playlists/Settings)
  3. Navigate back to Library

Unexpected behaviour

Library view shows top of view

Expected behaviour

Library view shows the track I clicked to play before I left the view

If you're reading and:

  • agree, then please vote up (e.g. +1, like), or;
  • disagree, then please vote down (e.g. -1, dislike) - I'd love to know why?

If you have any issues (e.g. questions/queries) then happy to help

Keep up great work!

Sincerely

hardware: Apple, MacBook Pro (16-inch, 2019) software - operating system: Apple, macOS, 10.15.3 (19D76) software - application: Museeks, 0.11.3 (0.11.3)

ldexterldesign avatar Mar 02 '20 19:03 ldexterldesign

I completely agree, this would be nice

qcasey avatar Mar 02 '20 19:03 qcasey

What I found regarding react-router-dom:

https://reacttraining.com/react-router/web/guides/scroll-restoration/generic-solution

qcasey avatar Mar 02 '20 19:03 qcasey

Scroll restoration won't work here as the scroll is not on the whole page but on a nested element.

I agree it should be done.

ps: careful with the phrasing, please don't be rude.

martpie avatar Mar 02 '20 20:03 martpie

ps: careful with the phrasing, please don't be rude.

Screenshot 2020-03-02 at 22 25 34

https://en.wikipedia.org/wiki/User_story#Principle

😁

ldexterldesign avatar Mar 02 '20 21:03 ldexterldesign

🙏

In the meantime, if it's easier to implement then could simply make the currently playing track more obvious (e.g. persist highlighting of the row):

Screenshot 2020-04-06 at 19 19 27

This animated icon is really hard to find:

Screenshot 2020-04-06 at 19 12 46

Persisting the view's (scroll) position could be next

Sincerely

ldexterldesign avatar Apr 06 '20 17:04 ldexterldesign

a question for everyone here: do you want it to remember the scroll position? Or what you want is actually it automatically scrolls to the playing track?

martpie avatar Jan 24 '21 19:01 martpie

@martpie

Remember scroll position would close this issue for me

Scroll to playing track is useful in some use cases but annoying in other use cases (e.g. I'm interacting with some non-playing tracks, adding to playlist etc. and then the view automatically scrolls away and I have to scroll back) so I would like an option to enable (default IMO) / disable that

Hope this helps

Sincerely

ldexterldesign avatar Jan 24 '21 20:01 ldexterldesign

Waiting on https://github.com/remix-run/react-router/pull/10468 to implement this. I'll definitely implement that as soon as the upstread PR gets merged and we have this available as a new API.

martpie avatar May 30 '23 13:05 martpie