Marton Bod
Marton Bod
Thanks a lot @mosabua for taking a first look. @electrum / @findepi please let me know if you have any thoughts, I do appreciate any input. Thanks a lot!
@findepi Thanks so much for your time to review this. I've tried answering your questions as best as I could. Please let me know if you have any other questions/improvement...
We have run TPC-DS 10000 (iceberg-parquet files in S3) with both our internal fork of 421, as well as 421 + this patch, and the results were identical (
@findepi @ebyhr @electrum just a friendly check-in to see if you could please take another look at this PR? Would greatly appreciate any comments, opinions or guidance from all you....
@mosabua Thanks a lot for the ping! I have rebased the PR and squashed the commits so it's ready to go again. If the tagged maintainers are too busy, is...
@raunaqmorarka @findepi I have rebased to the latest master - can you please give this a review? It's been inactive for some time now so would be great to make...
I've had some conversations offline with @raunaqmorarka , who is currently on vacation but will check the PR once he's back next week.
@raunaqmorarka I've addressed your latest comments - please take another look to see if it's good to go now. Thanks! The only test failure is unrelated (TestHiveTransactionalTable > testReadFullAcid)
@raunaqmorarka Thanks again for reviewing this PR. I've addressed your latest comments. The tests are green, so it's ready for another pass. Couple of notes: 1. I have not turned...
@raunaqmorarka I have rebased to the latest master. Please take a look again, it should be good to go now. Thanks a lot!