Martin Leitner-Ankerl

Results 93 comments of Martin Leitner-Ankerl

I don't know much about how the CI works, maybe it's possible to install a newer clang version? I'm using 15.0.7

ACK 03ec5b6f9ca3af28c9ce25cf2393e28ae852d808

Code review ACK ebfc2a2dddedcbf384f435716d30d8418a77505b and ran `git rebase --interactive upstream/master --exec 'make clean && make -j14 check'`. Btw. I really links to the changes in your PR updates. Do you...

re-ACK 95ad70ab652ddde7de65f633c36c1378b26a313a

re-ack 52129e335cbc68ac5d863f283f7d1a328ce79581

code review ACK 2235765f7fd946d3b08fd9e109584967407e46d1, also rebased & built & tested each individual commit with `make check`

@sipa While rebasing #25325 I saw that the fuzzer in `coins_view.cpp` still uses `CCoinsMap coins_map;` and doesn't use the deterministic seeds, shouldn't this fuzzer do that as well? I can...

> I believe it does? It does [in line 49 for `CCoinsViewCache`](https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/coins_view.cpp#L49), but not [in line 118 for the `CCoinsMap coins_map;`](https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/coins_view.cpp#L118). I've added that in #25325 [here](https://github.com/bitcoin/bitcoin/pull/25325/commits/78f597be2879c39d9d2b98e21ed0120d2308de20#diff-1ef3b6a1936b50f3d5ec4a1786d9e2d63d1a3e1815b103e67f20601995f355b4R119)

I can confirm that #29000 is fixed for me in commit 76d0c07ee94b8720964d9d71d462550ecc8b5147.