Martin Stark

Results 45 comments of Martin Stark

@avelad @joeyparrish I agree, the root cause seems to be that modern EME support is broken when playing natively through Shaka. I don't have ready access to an Apple laptop...

> does the fix for #4431 relieve the need to switch? Yes, for our particular use case it does, thank you very much for fixing it (testing it right now...

Will re-open once I run some more tests.

Thanks @joeyparrish, I'll look at adjusting according to your feedback and add a test as well as docs

@avelad @joeyparrish I've addressed the feedback, introduced unit tests and added a short blurb in the documentation. I opted for not restricting the unit test to only run on Safari....

@avelad managed to finally get through linting :sweat_smile: ```bash 1) cues ending exactly now TextDisplayer layout using browser-native rendering native-end-time-edge-case: Expected 0.9133498736570255 not to be less than 0.95. ``` I...

@avelad the safari test still fails, I've rebased on the lastest `main` to see if that makes a difference

```bash 1) cues ending exactly now TextDisplayer layout using browser-native rendering native-end-time-edge-case: Expected 0.9133498736570255 not to be less than 0.95. ``` Keeps failing with exactly the same number. I've had...

@avelad I tried to remove the unit tests to see if that's what was causing the Safari test suite failure. I've reverted this and squashed everything. Thanks for your time!