martinsbalodis
Some new features
Hi,
I added two features and offer to add them into the parent branch.
First, it is date pattern support for start url:
and second, limit for Click and Scroll Selectors (scrape only first 3 pages, for example):
You should include your DateUtils scripts in SpecRunner.html to prevent errors in the unit tests. It would be also great if you could write some unit tests for your features - it is self explaining if you have a look into the tests folder.
It's very strange... At me all tests are green.
It is also strange that only two fails. Case 'SimpleDateFormatter.parse' pattern 'MM/dd/yyyy' is normal?
Yes, only the two I posted are failing. Try to change your time zone on your system. I can reproduce different values 2h, 3h difference depending on the timezone.
@jwillmer I think my pagination limit and #178 do the same thing, merge them together is not a good idea.
The difference is that #178 applies only to ElementClick, my option applies to ElementClick and ElementScroll.
My timezone is +3 and all fine. Try replacing the dot with an underscore (dd_MM_yyyy and 16_06_2016). Will the test result change?
No, sadly changing the format to parse does not change the outcome.
@jwillmer I think my pagination limit and #178 do the same thing, merge them together is not a good idea.
I looked at both implementations and you are right. I will remove #178 since it is a feature duplication.
Update: #178 removed and documentation extended
It should not be. On my computer, the date is created the same.
new Date("1970-01-01T00:00:00.000Z");
Thu Jan 01 1970 03:00:00 GMT+0300 (RTZ 2 (зима))
new Date(0);
Thu Jan 01 1970 03:00:00 GMT+0300 (RTZ 2 (зима))
About the creation of the date in javascript, the following is said:
-
Using new Date(number), creates a new date object as zero time plus the number. Zero time is 01 January 1970 00:00:00 UTC. The number is specified in milliseconds.
-
The ISO 8601 syntax "YYYY-MM-DDTHH:MM:SS.SSSZ" is also the preferred JavaScript date format. UTC time is defined with a capital letter Z.
In both case must be UTC timezone.
Also, it's not clear why the test 'MM/dd/yyyy' passes. I give up.
I will create a workaround for my use case and write a log message if this case happens:
https://github.com/jwillmer/web-scraper-chrome-extension/commit/7455e3b50ff923322d8787b6f50297b2fc03fb81
Sorry for me deleted post but toUTC does not fix it. The workaround I posted does fix it.
Hi everyone,
I'm trying to add the "pagination limit" feature code into the webscraper.io proram. Does anyone know how to do this? Also which code is specifically for the "pagination limit" function?
Thanks in advance!
@Asp1ringC0d3r If you read the tread you would see that I already merged it:
Cool, merged in my fork. Thank you!
@jwillmer I'm a hobbyist when it comes to coding. What do you mean by merged it? Is it already a feature in the webscraper.io?
@Asp1ringC0d3r based on your comments you should not try to add (merge) the pagination limit feature yourself. Have a look at my project copy (fork). I included (merged) all open features (pull requests).
@jwillmer I already have the chrome extension. How do I install your project copy to access all the open features?
@Asp1ringC0d3r Read the readme. If that does not help open an issue in my project, this is not the place for it.