imbox icon indicating copy to clipboard operation
imbox copied to clipboard

move message-modifying methods from Imbox to Struct

Open zevaverbach opened this issue 7 years ago • 6 comments

To be more "for humans". 😄 Would you accept a PR implementing this?

zevaverbach avatar Jul 26 '18 13:07 zevaverbach

Also, having done this, update a Struct's fields whenever such a method is called.

zevaverbach avatar Jul 26 '18 13:07 zevaverbach

@martinrusev having made this change, Struct (aka Message) could have lots of properties for flagged, read, unread, etc.

zevaverbach avatar Jul 27 '18 18:07 zevaverbach

>>> messages = Imbox.messages()
>>> m = messages[0]
>>> m

Message(sent_from='[email protected]'
        date_sent=datetime.datetime(2018, 7, 27, 14, 37)
        subject='thank you for merging my PR'
        body='')

>>> m.read
True
>>> m.unread
False
>>> m.mark_as_unread()
>>> m.unread
True

zevaverbach avatar Jul 27 '18 18:07 zevaverbach

@martinrusev checking in with you on this. Would you accept a PR implementing this?

zevaverbach avatar Oct 18 '18 17:10 zevaverbach

@zevaverbach that will be a good addition.

martinrusev avatar Oct 18 '18 19:10 martinrusev

was there a PR ?`

erSitzt avatar Mar 11 '21 14:03 erSitzt