vJCRE

vJCRE copied to clipboard

Missing constant in ISO7816.java

5

The constant SW_COMMAND_CHAINING_NOT_SUPPORTED is missing Reference: http://www.win.tue.nl/pinpasjc/docs/apis/jc222/javacard/framework/ISO7816.html#SW_COMMAND_CHAINING_NOT_SUPPORTED Underlying code: https://github.com/martinpaljak/vJCRE/blob/85c7828089fcde0fa8cde89a622b5ec582804947/src/javacard/framework/ISO7816.java missing line: short SW_COMMAND_CHAINING_NOT_SUPPORTED = 0x6884;

vletoux

Please check this again. protected void setValidatedFlag(boolean value) { validated = **false**; // ??? I think that It is "validated = **value**;" }

DaoThanhLong

Indeed in VRE.transmit, you do not get the size of the array sent (https://github.com/martinpaljak/vJCRE/blob/master/src/pro/javacard/vre/VRE.java#L207-L211) So when APDU.receiveBytes is called: - the data copy to the APDU buffer is not made...

vletoux

sendBytesLong doesn't throw an exception if setOutgoingLength not called

1

According to http://www.win.tue.nl/pinpasjc/docs/apis/jc222/javacard/framework/APDU.html#sendBytesLong%28byte[],%20short,%20short%29 "throws:(...) APDUException.ILLEGAL_USE if setOutgoingLength() not called or setOutgoingAndSend() previously invoked or response byte count exceeded or if APDUException.NO_T0_GETRESPONSE or APDUException.NO_T0_REISSUE or APDUException.NO_T0_REISSUE previously thrown. " Indeed no...

vletoux

reproduce: kp = new KeyPair(KeyPair.ALG_RSA_CRT, KeyBuilder.LENGTH_RSA_1024); kp.genKeyPair();

vletoux

vletoux

vletoux

OwnerPIN check and update issue when using an offset

2

in /src/javacard/framework/OwnerPIN.java (https://github.com/martinpaljak/vJCRE/blob/85c7828089fcde0fa8cde89a622b5ec582804947/src/javacard/framework/OwnerPIN.java) The **offset** parameter of the functions **check** and **update** is not used. My opinion is that: Util.arrayCopy(pin, (short)0, value, (short)1, length); should be changed to Util.arrayCopy(pin, offset,...

vletoux

The tool is very good. However it is difficult to test functions involving selectingApplet() returning true except doing test with a hardcoded value of "true". Hopefully, this is case only...

vletoux