expected-lite icon indicating copy to clipboard operation
expected-lite copied to clipboard

C++20 `__cplusplus value`

Open xavier2k6 opened this issue 1 year ago • 9 comments

Shouldn't the __cplusplus value for C++20 be 202002L as per https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-170

https://github.com/martinmoene/expected-lite/blob/b33d22b294865cdb94e557d779a25ff2096ba618/include/nonstd/expected.hpp#L103

xavier2k6 avatar Aug 03 '22 23:08 xavier2k6

Thanks, sure :)

C++20 had been speculative:

https://github.com/martinmoene/expected-lite/blob/b33d22b294865cdb94e557d779a25ff2096ba618/include/nonstd/expected.hpp#L88

martinmoene avatar Aug 04 '22 10:08 martinmoene

C++20 had been speculative:

https://github.com/martinmoene/expected-lite/blob/b33d22b294865cdb94e557d779a25ff2096ba618/include/nonstd/expected.hpp#L88

👍

Maybe, that can now be changed to (C++23 is speculative) if you make the other change/release. 🤣

xavier2k6 avatar Aug 04 '22 12:08 xavier2k6

@martinmoene I'm not sure if you are aware but the 2016 runner images have been removed from github actions..... only 2019/2022 are available now as of 31st July.......CI needs to be updated too.

xavier2k6 avatar Aug 04 '22 19:08 xavier2k6

@xavier2k6 ah, thanks, wasn't aware of it yet.

martinmoene avatar Aug 04 '22 19:08 martinmoene

@martinmoene AppVeyor is still showing Queued? Will there be a 0.6.2 release anytime soon?

xavier2k6 avatar Aug 07 '22 10:08 xavier2k6

@xavier2k6 will try to release 0.6.2 today-ish.

martinmoene avatar Aug 07 '22 10:08 martinmoene

@xavier2k6 expected-lite 0.6.2 released, conan update PR sent.

martinmoene avatar Aug 07 '22 12:08 martinmoene

Dunno yet what'sup with AppVeyor...

martinmoene avatar Aug 07 '22 12:08 martinmoene

I don't think I can help you with that......may have just been a glitch in the matrix! 🤣

xavier2k6 avatar Aug 08 '22 13:08 xavier2k6