laravel-vue-i18n-generator icon indicating copy to clipboard operation
laravel-vue-i18n-generator copied to clipboard

Published 20 hours ago • verified publisher icon martinlindhe

Configurable extension

Open tomeus opened this issue 5 years ago • 2 comments

When choosing format as json it could be a fine generating file with json extension.

Maybe rename jsPath and jsFile to outputPath and outputFile, add outputExtension.

tomeus avatar Jun 04 '19 11:06 tomeus

I would welcome a patch if you find it needed, but just add outputExtension.

We want to avoid breaking existing configurations so I rather keep the jsPath and jsFile names for now, even they are a bit annoying in hindsight.

martinlindhe avatar Jun 05 '19 17:06 martinlindhe

Hi. I have found the time and I return to this. I review the implementation again and say that this configuration parameter will only be taken for generateMultiple. Does it make sense to you? I'm also new in contributing, do you have any special pull request requests?

tomeus avatar Mar 14 '20 10:03 tomeus