MartinDotNet

Results 130 comments of MartinDotNet

I'm asking for examples with OpenTelemetry, or even just telemetry tools. The .NET OpenTelemetry code base shouldn't be breaking from what the other libraries do, whether that's in the spec...

In light of the above, I've removed help-wanted for now, until there is an actual decision on whether this would be accepted. The decision should come in the form of...

This was discussed on the SIG today and the outcome was that JSON should be the default, with the option to use YAML. We discussed various issues, and although there...

I think what we should be doing here is probably using the `OTEL_EXPORTER_OTLP_ENDPOINT` to configure it, rather than the code. I could see something more that does a dynamic lookup...

Could you override this in the HttpClientFactory? ```csharp builder.Services.AddOpenTelemetry() .WithTracing(tpb => { tpb.AddOtlpExporter(o => { o.HttpClientFactory = () => { return new HttpClient( ... ); }; }); }); ```

I think that changing headers that have been added should require that extra work. I do think that it should be handled better. So saying "you cannot amend existing headers"...

I believe this the same as #5515, which is being fixed. If that seems right, we can close this in favour of that.

I'm going to remove the bug label here and close this as resolved. The issue isn't part of OpenTelemetry, or one we are going to fix. It requires upstream fixes...

Reopened. My perception was that it wasn't a fix, just making a different, potentially better, error message. If you think it's worth keeping this open while we add a better...

Are you happy, with that PR merged, that we close this?