mooshika

mooshika copied to clipboard

Would you like to add more error handling for return values from functions like the following? - [pthread_create](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_create.html "Thread creation") ⇒ [msk_connect](https://github.com/martinetd/mooshika/blob/503a4e3cb5ca63474cc85710dc3435c0c1e6c83e/src/trans_shm.c#L588) - [pthread_mutex_lock](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_lock.html "Lock a mutex") ⇒ [msk_check_create_epoll_thread](https://github.com/martinetd/mooshika/blob/188439e9a6e46f551516915a90c52abed80bd296/src/trans_rdma.c#L390)

elfring

I would like to point out that identifiers like "[`_MOOSHIKA_H`](https://github.com/martinetd/mooshika/blob/7ff224dced50945251b4236fd4e3e5bdee155dfb/include/mooshika.h#L32)" and "[`_RMITM_H_`](https://github.com/martinetd/mooshika/blob/edf11d45fe94132a6cbbfb125d83516284dbd4d0/src/rmitm.h#L7)" [do eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to...

elfring