Martin Trapp
Martin Trapp
Hi @Ananto30, I covered codegen.py with my latest commit. I've also found solution to cover Pydantic V1 import but it does not tests the code with V1 actually. I'm currently...
Hi @Ananto30, sorry for keeping you waiting. Unfortunately, I wasn’t able to figure out a proper way to test the `ImportError` scenario, as I couldn’t rerun the top-level module imports...
Hi @Ananto30, I’d like to get this PR finished — could we discuss how to move forward? There are at least two issues I’ve noticed: 1. `issubclass(typ, BaseModel)` raises a...
Any thoughts @Ananto30?
That's right. Not only the `sync` but `save`, `set`, `update` and all methods relying on `merge_models` ingore Link fields. I think #653 is related. This part ignores the field if...
Can someone from the core development team answer whether this was intentional or not? Perhaps we can then submit a fix for it? @roman-right @07pepa
@staticxterm, it's not just `sync`, but all other methods that use `merge_models` are also affected, particularly `save` and `update`. The reason I think it was intentional, as it explicitly checks...
I'll send a fix once I have some time for it.
Can't we just compare if really the `revesion_id` was what changed or another field? I agreee with OPs solution. Maybe it's not bulletproof but works out of the box.
I've checked just to be certain. The unit tests are passing correctly. I believe there's something wrong with the CI. Could you please take a look at it? ```bash Set...