Martin Costello
Martin Costello
Taking a quick look at the code, this is by design. The user-supplied `CancellationToken` is combined with another `CancellationToken` for the timeout: https://github.com/App-vNext/Polly/blob/addc946c2357ce1c0411abe40100a73f761006a5/src/Polly/Timeout/AsyncTimeoutEngine.cs#L24 The combined token is then passed through...
I'm not sure if it _definitely_ is a breaking change, but adding a new generic type as the base class of `PolicyRegistry` _feels_ it on a binary level, even if...
Off the top of my head, I think a rough plan if we went down the generic class route (rather than a rename) would be: 1. Raise a PR here...
If you're limiting yourself at the client (rather than the server doing it), would maybe a [bulkhead policy](https://github.com/App-vNext/Polly#bulkhead) work for you? With an appropriate limit on the number of actions...
> perhaps I could combine it with the rate-limiting code from #666 using PolicyWrap? Certainly worth a try to see if you can get any mileage out of it. I've...
There's not enough here to repo as-is (where's the DbContext code, for instance), but looking at what you've provided you aren't using the fallback in your Policy Wrap. Do you...
Sorry, my mistake you are using the fallback. It's just using a different style of configuring it than I'm used to (I use the `Policy.Wrap(a, b, c)` style) and I...
Sorry for the delayed reply - yes, `onRetry` is for you to do custom things when a retry happens, such as logging a message or emitting a metric. It's isn't...
There is no progress regarding this issue.
Looking at the comments from Dylan above, it sounds like this will be addressed in v8. However, v8 development is currently on hiatus so I can't say when it would...