Martin Sucha

Results 163 comments of Martin Sucha

Default timeout in gocql.query

WriteTimeout was introduced in https://github.com/gocql/gocql/commit/1268384b22aeea6ae7f83661763abb24bc7f951d, previously the same timeout was used for writing as for reading (which is also default in newer versions if you don't specify WriteTimeout explicitly). However,...

chore: use buf.String() instead of string(buf.Bytes())

Hi! Thank you for the pull request! The change looks good to me, but I have two questions: - You have [Github vigilant mode](https://docs.github.com/en/authentication/managing-commit-signature-verification/displaying-verification-statuses-for-all-of-your-commits#about-vigilant-mode) enabled, but the commit is not...

If DisableInitialHostLookup, Update Hosts On First Ring Refresh

Hi! Thanks for the pull request! In general the change looks good to me. Could you please update AUTHORS file as per [CONTRIBUTING.md](https://github.com/gocql/gocql/blob/master/CONTRIBUTING.md#minimum-requirement-checklist)? Also it seems that some tests are...

suggestion for Unmarshal version 2

Hello! Indeed the reflection in gocql.Unmarshal is slow. At kiwi.com, we use https://github.com/scylladb/gocqlx and https://github.com/kiwicom/easycql in production for faster unmarshaling. A better interface directly in gocql would be nice indeed....

Commitlog handling

It seems to me that this can and should be implemented in an external library, not part of the core gocql. Each CQL database implementation (Cassandra, Scylla, ...) has a...

Commitlog handling

> My aim is to stream Cassandra CDC to Knative Eventing CloudEvent channel with a custom Apache Arrow marshaling and processing (flatbuffers IPC easier to optimize). And I'd like to...

`system.peers` queried even if `DisableInitialHostLookup` set to `true`

Thanks for raising the issue. It seems the behavior was like this since commit 83932d6de9af9257339038f8a3a017941c34921d that introduced the option. It seems reasonable to me to treat this as a bug...

Scanning a JSON object

`SELECT JSON` encodes multiple database columns as json, so if the values text is json, it would be encoded twice. Try using a plain `SELECT values ...` instead. Also your...

Exec() returning ErrNotFound

Hi @arvy, I don't see how this could happen for an insert query. Please, do you have any steps how to reproduce the issue?

Rewrite integration test setup in Go

It's fine to bump the minimum required Go version to 1.21, we have the following [notice in the README](https://github.com/gocql/gocql?tab=readme-ov-file#sunsetting-model): > ## Sunsetting Model > In general, the gocql team will...