Martin Henz comments

Results 101 comments of


                                            Martin Henz

add the comment to link the specification

It seems that this PR is not difficult to fix so that it can be merged. @FYL2003 can you take another look please.

[math]: math_hypot should take any number of arguments

this issue persists as of today.

Import Cycle Detection throws unhandled error when graph is not fully a cycle

Does the program to be run need to be part of the cycle? In my view, importing a module that cyclically depends on some other module is ill-defined.

Import Cycle Detection throws unhandled error when graph is not fully a cycle

I see. We should catch this error and display a more reasonable error message. Something like: "program /playground/program.js has cyclic dependencies in its import declarations"

Implement name-refactoring for the module import directives

Yes, this renaming (aka "refactoring") should be possible with Ctrl-M, see https://github.com/source-academy/frontend/wiki/Source-Academy-Keyboard-Shortcuts

Implement name-refactoring for the module import directives

Reminder: @hungkhoaitay you are probably uniquely qualified to fix this. If you have time.

Rewrite shell build script in JS

See here for background: https://github.com/source-academy/js-slang/issues/691

String representation is not language dependent

Haha, fair enough. Need to see what's the canonical Python representation of estrees. I think we can work something out if we are willing to be a bit generous.

Incorrect Error for ExportNamedDeclarations with sources

Yes, Source syntax should explicitly forbid the export syntax ``` export { show, heart } from 'rune'; ```

NATIVE: depth of display of values in REPL error messages

This program now produces a nice error message in the REPL: Line 31: Potential infinite recursion detected: stack_frac(0.9953271028037384, { "isPrimary": false, "transMatrix": { "0": 1, "1": 0, "2": 0, ......