Martin Grigorov

Results 780 comments of Martin Grigorov

@mkmkme Do you have time to review this PR ?

I was not aware of this PR. I also worked on the Bioconda recipe to build packages for more platforms - https://github.com/bioconda/bioconda-recipes/pull/46644 It is a duplicated work for now! Once...

> Would it make sense to kill the windows build for now, and get this working for the linux side +1

Using `nightly` toolchain one can see how fast/slow a test is. For example the `add_documents` IT tests: ``` cargo +nightly test documents::add_documents:: -- -Z unstable-options --report-time ``` ``` running 39...

@irevoire I think `meilisearch/tests/search/locales.rs` should be removed from the list above. All its tests modify the settings, e.g. ```rust index .update_settings(json!({ "searchableAttributes": ["product"], "localizedAttributes": [ // force swedish {"attributePatterns": ["product"],...

@irevoire All the listed tests but the Auth tenant ones are addressed! About the Auth tenant ones: `server.use_api_key(...)` makes it hard to reuse a shared server. We can add `server.use_api_key("MASTER_KEY");`...

I think the same! I have some more ideas for minor improvements. I'll send PRs soon!

I have opened: * https://github.com/meilisearch/meilisearch/pull/5697 * https://github.com/meilisearch/meilisearch/pull/5698 * https://github.com/meilisearch/meilisearch/pull/5699 * https://github.com/meilisearch/meilisearch/pull/5700 Once merged I will open the last one that removes Index::wait_task() completely and updates the rest of the files.

> Once merged I will open the last one that removes Index::wait_task() completely and updates the rest of the files. https://github.com/meilisearch/meilisearch/pull/5703