redmine_custom_css icon indicating copy to clipboard operation
redmine_custom_css copied to clipboard

minified javascript in source tree

Open onlyjob opened this issue 9 years ago • 1 comments

Minified javascripts are effectively the same as pre-compiled binaries -- un-readable, non-modifiable and non-distributable in Debian. It is the best to have no minified files in source tree at all.

Please consider removing minified file assets/javascripts/codemirror.min.js.

Removing this file requires the following patch:

--- a/app/views/settings/_custom_css.html.erb
+++ b/app/views/settings/_custom_css.html.erb
@@ -1,6 +1,6 @@
 <%= stylesheet_link_tag 'codemirror', :plugin => :redmine_custom_css %>
-<%= javascript_include_tag 'codemirror.min', :plugin => :redmine_custom_css %>
+<%= javascript_include_tag 'codemirror', :plugin => :redmine_custom_css %>

 <style type="text/css">
     .CodeMirror {
         height: auto;

Thanks.

onlyjob avatar Jul 01 '15 03:07 onlyjob

Out of curiosity. Would specifying a "SourceMap" solve elegantly the problem? Explanations about Source Maps: http://blog.teamtreehouse.com/introduction-source-maps

martin-denizet avatar Oct 10 '15 21:10 martin-denizet