Martijn Vermaat
Martijn Vermaat
Thanks for the patch @myourshaw! I agree, but this will break quite some existing code. Perhaps we should adding some tags to this and similar proposals, to make it easier...
Thanks @gitanoqevaporelmundoentero for the pull request. I have also seen your earlier comment, but haven't had time to respond to it. Let me just link to #82 as a reference...
Yes, we should try to merge this. It would take some time for me to go through it, but just skimming I see a number of issues I would like...
Some workflow related points: 1. I don't think you should have merged with current master during your work. Since we don't have any guidelines on this, I really cannot blame...
Sorry for not getting here earlier. I think there are still some issues to be resolved before this can be merged, but a full review will take me a lot...
It's safe to include tests in the PyPI package and you can control in setup.py whether or not they are installed. That running them requires consul shouldn't be an issue....