clew
clew copied to clipboard
Possible improvements in CMake configuration
Hi!
I've looked through the project build configuration, and I found few moments I can improve it:
- Merge all
CMakeLists.txt
into a the topmost one. You cannot build only part of the project by issuingcmake ../src
orcmake ../clewTest
, so why have them separated at all? - Options like
BUILD_TESTS
orBUILD_SHARED_LIBRARY
should haveCLEW_
prefix in their name. - Maybe rename
clewTest
directory toclew_test
or simplytest
?
What you you think about the proposal? Option renaming is a breaking change, so I'd want to discuss it prior PR'ing. See the EasyCL issue discussion for more information why this rename maybe a right thing to do.