sign-up-for-facebook icon indicating copy to clipboard operation
sign-up-for-facebook copied to clipboard

Set cursor to pointer for button.accept

Open mrpandey opened this issue 6 years ago • 2 comments

It took me time to realize that "I'm OK with this" is a clickable button. I realized this when I scrolled to the bottom and wasn't able to click "Sign up for Facebook" button.

So I added cursor: pointer to button.accept and also added a darker box-shadow on hovering button.accept.

You can easily see changes here: https://mrpandey.github.io/sign-up-for-facebook/

mrpandey avatar Jun 06 '18 20:06 mrpandey

Hmm, buttons shouldn't really have cursor: pointer. It's only for links, right?

(I do agree that the buttons can be made much more…button-like.)

martenbjork avatar Jun 07 '18 09:06 martenbjork

There were historical reasons for using cursor: pointer only for links. Back in the days, buttons were clearly distinguishable by their 3D inset looks.

But nowadays, flat-design is the norm. Web devs use pointer for a anything that triggers some action. Some examples would be github star button, facebook like button, youtube play-pause, youtube subscribe button, etc.

But yes, changing cursor to pointer isn't the only way. Adding the gradient background is another option.

mrpandey avatar Jun 07 '18 13:06 mrpandey