marta-issues icon indicating copy to clipboard operation
marta-issues copied to clipboard

Panel actions should't be executed when the etty has the focus

Open sedovalx opened this issue 6 years ago • 3 comments

I changed the default key bindings the next way

    "keyBindings": {
        "core.open": ["Right", "Return"],
        "core.go.up": ["Left", "Backspace"],
    },

Now, when I open etty (Cmd+O) and start to enter a previously used command there is a suggestion to complete the command (it is a zsh feature). To complete I need to press the "Right" button. When I do it the current folder changes reacting on the pressed key and I lose the entered symbols in the etty.

I suppose, panel navigation actions shouldn't be executed when a user works with etty.

sedovalx avatar Apr 07 '18 21:04 sedovalx

Panel actions were initially supported in etty for several actions like tab switching. But I realize it really causes problems, so probably we should allow only hotkeys with the Cmd modifier (it's not allowed in terminal anyway). Also the hotkeys could explicitly say they're allowed to be run in the terminal context (the default is "no").

yanex avatar Apr 15 '18 10:04 yanex

I think this is a related issue: I changed my left/right cursor keys:

keyBindings {
    "Left" "core.go.up"
    "Right" "core.open"
}

but these keys are still active in navigation, rather than in moving the cursor in the terminal.

reagle avatar Apr 25 '22 14:04 reagle