marshmallow icon indicating copy to clipboard operation
marshmallow copied to clipboard

RFC: Remove implicit field creation

Open sloria opened this issue 5 years ago • 4 comments

Proposal: Remove Implicit/inferred field creation (fields and additional class Meta options).

At the very least, it's an unnecessary feature that adds complexity to the codebase. At worst, it interacts in weird ways with consuming libraries that autogenerate fields (see #923). The feature was added pre-1.0, when there were no ORM integration libs, as a poor man's ModelSerializer. At this point, though, I think we can remove it.

sloria avatar Aug 20 '19 09:08 sloria

To clarify, do you still plan to keep the Schema class meta unknown?

    class Meta:
        unknown = INCLUDE

MikeBadescu avatar Sep 02 '19 22:09 MikeBadescu

Yes, the unknown field API will remain the unchanged.

sloria avatar Sep 02 '19 22:09 sloria

Thank you!

MikeBadescu avatar Sep 02 '19 23:09 MikeBadescu

Let's consider this accepted for 4.0.

sloria avatar Mar 30 '21 04:03 sloria