Marcel Zięba

Results 127 comments of Marcel Zięba

> I think it make sense but also could entail a dead lock. If someone else has a lock on the entry, the node map could no longer be read....

@pchaigno I wonder which CI test runs IPSec privileged test? I wanted to double-check it runs, I was thinking that probably `Conformance Runtime (ci-runtime)` but junit shows 0 for privileged:...

@sjdot I do agree that we should use `XfrmStateGet` and probably this part needs some refactoring in general. While `XfrmStateGet` would work for background-sync triggered events which usually don't change...

> I see the usefulness of the caching given this, I'm just nervous given our long history of very painful ipsec issues. Given it's a pretty significant change, do you...

So I've tested it manually as well to make sure that flag works, we can disable caching by following helm values: ``` extraArgs: - --enable-ipsec-xfrm-state-caching=false ``` I intentionally made this...