marschwar

Results 48 comments of marschwar

Don't get me wrong, but is this really a problem in die wild that needs its own rule? I know this is not a binary expression but this is essentially...

> @marschwar The rule will report an issue in the line `if (foo || baz || foo) { ` I tried and it does not.

To me the [documentation](https://kotlinlang.org/docs/kotlin-doc.html#property-name) seems to suggest that this is reserved for properties that are defined in the primary constructor. I have not checked if that is supported by detekt...

From a readability standpoint I prefer `list != null && list.any { it == 4 }`

You are right. `throw e.toMyException()`should be considered equivalent to `throw toMyException(e)` but it is not. Thank you for reporting this. Would you like to look into the issue yourself and...

You might be right. Since there really is no way of knowing if the extension function swallows the exception or not this may not be possible at all. The extension...

Looking at the tests for the rule it looks to me that you either do something with the exception (without rethrowing) or you throw an exception using the exception as...

As a matter of fact, we are currently revisiting the severity concept for detekt. See #6383 Please do join the conversation there.

How should we handle rules that do not rely on type resolution to run but use the `AnnotationExcluder` to support custom exclusions. Specifically this is the case in `LongParameterList`, `LateinitUsage`...

> Not a duplicate: this is about unnecessary fully qualified names, while the other issue is about redundant imports. While it is not a duplicate the comment I referenced also...