puppet-alfresco icon indicating copy to clipboard operation
puppet-alfresco copied to clipboard

reset-password addon not included?

Open marsbard opened this issue 10 years ago • 6 comments

maybe this got excluded at some point? I think the source manifest is still there as that's what I built the feature list from

marsbard avatar Jun 03 '15 21:06 marsbard

its in modules/deploy, we didnt find a way to auto deploy it, this might be something fixable in newer releases?

https://localhost:8080/share/page/modules/deploy

digcat avatar Jun 04 '15 03:06 digcat

http://docs.alfresco.com/4.2/concepts/dev-extensions-share-module-autodeploy.html could be relevant

marsbard avatar Jun 04 '15 09:06 marsbard

From Angel:

It’s needed an true at https://github.com/share-extras/reset-password-dialog/blob/master/config/alfresco/site-data/extensions/reset-password-module.xml

So maybe we can override this when we unpack it?

marsbard avatar Jun 04 '15 09:06 marsbard

other modules enable by default, is this by design?

digcat avatar Jun 04 '15 15:06 digcat

Yeah they probably set the extension.

but there was a bit more conversation in email: Angel:

Regarding this issue (https://github.com/marsbard/puppet-alfresco/issues/81), because of reset-password-dialog addon has no “autodeploy” mark at extension declaration (https://github.com/share-extras/reset-password-dialog/blob/master/config/alfresco/site-data/extensions/reset-password-module.xml).

What we cand do? Modify this file once downloaded for Puppet or fork original project to include this directive? Or is there any other possibility?

Me:

To be honest I was thinking about enabling auto-deploy globally, I will need to find again where it is, I think it was in share-config.xml so could probably override in share-config-custom.xml

Angel:

This is the “other possibility” and I think is the good one ;-)

I think it is too, it's totally possible to turn this on and off per addon with the override as described but I can't see a use case, for us, which wouldn't want to see all modules autodeployed.

marsbard avatar Jun 04 '15 18:06 marsbard

pull requests welcome against this template:

https://github.com/marsbard/puppet-alfresco/blob/master/templates/share-config-custom.xml.erb

the only thing you need to know about templates is they are ruby ERB templates, you will see the non-templated parts stubbed out like <%= @share_host %> which will be replaced by the share_host variable in puppet (most of the important variables will be defined in manifests/init.pp)

marsbard avatar Jun 04 '15 19:06 marsbard