Tending Crop time
Describe the bug/issue
- Tending crop time is not valid at the end of the harvest
Actual/Observed Behaviors
00-Adir-03:059.014 (Info) Fishery : [Port Braun] Large Greenhouse 1 - Weeds fully tended for 54.0 millisols.
00-Adir-03:069.651 (Info) PlanMission : [Port Braun] Ashley Harris - Looking into the settlement's mission needs.
00-Adir-03:069.651 (Info) PlanMission : [Port Braun] Ashley Harris - Determined that the settlement doesn't need a new mission.
00-Adir-03:072.676 (Info) Crop : [Port Braun - Large Greenhouse 1] Daniel King - Harvested a total of 102.99 kg Strawberry.
00-Adir-03:072.676 (Info) Crop : [Port Braun - Large Greenhouse 1] Daniel King - Closed out the final harvest of Strawberry.
00-Adir-03:072.676 (Warning) Mind : [Port Braun] Daniel King - 'Tending Crops' returned a remaining time 17848.68359017087 larger than the original 0.04037161531203451
00-Adir-03:073.359 (Info) DigLocalRegolith : [Port Braun] Terry Allen - Checking in 43.4 kg regolith.
00-Adir-03:073.835 (Info) Farming : [Port Braun] Large Greenhouse 1 - 0.35 kg potato tissue-culture was fully available.
00-Adir-03:073.835 (Info) Crop : [Port Braun] Large Greenhouse 1 - Done growingPotato's tissue-culture. Transferring its plantflets to the field.
00-Adir-03:073.835 (Info) Farming : [Port Braun - Large Greenhouse 1] Ashley Harris - Planted a new crop of potato.
Specifications
- r6275
Another one:
00-Adir-02:535.423 (Info) Crop : [Garvin Station - Inflatable Greenhouse 1] Roy Brown - Harvested a total of 104.14 kg Swiss Chard.
00-Adir-02:535.423 (Info) Crop : [Garvin Station - Inflatable Greenhouse 1] Roy Brown - Closed out the final harvest of Swiss Chard.
00-Adir-02:535.423 (Warning) Mind : [Garvin Station] Roy Brown - 'Tending Crops' returned a remaining time 1875.9268922390265 larger than the original 1.153474723200986
00-Adir-02:551.341 (Info) Farming : [Garvin Station] Inflatable Greenhouse 1 - 0.1 kg soybean tissue-culture was fully available.
00-Adir-02:551.341 (Info) Crop : [Garvin Station] Inflatable Greenhouse 1 - Done growing Soybean's tissue-culture. Transferring plantflets to the field.
00-Adir-02:551.341 (Info) Farming : [Garvin Station - Inflatable Greenhouse 1] Roy Brown - Planted a new crop of soybean.
I found a few design issues that need to be addressed.
-
The addWork() in Farming has a while loop to continuously look for the next needy crop. This is unneccesary. Each frame should just look for one needy crop to tend.
-
The addWork() in Crop has some big issues. It doesn't track how much work time or attention a crop needs at the moment.
-
And
currentPhaseWorkCompletedin addWork() in Crop should be per crop and per growing area (square meter). Currently, it's only per crop. Therefore, the large the growing area, the longer and more work time it would need.