vermouth-martinize icon indicating copy to clipboard operation
vermouth-martinize copied to clipboard

Processor multiprocessing

Open mjtadema opened this issue 4 years ago • 4 comments

This is what i came up with for multiprocessing in the base run_system method. It will always fall back to the old method if nproc is not set. So far it seems to work fine in combination with my changed make_bonds function in #234 .

mjtadema avatar Mar 04 '20 10:03 mjtadema

It seems we need to add a test for run_system with multiprocessing, but I am not entirely sure where to put it..

mjtadema avatar Mar 04 '20 14:03 mjtadema

Some small comments. The downside of this approach is that every Processor being run creates it's own Pool of processes, which might create a lot of overhead. I'm not sure how bad it is though.

Instead of setting the class attribute nproc and creating the pool in run_system, maybe we can set the attribute to be the actual pool itself. That way the same pool should be shared among all processors, no?

mjtadema avatar Mar 04 '20 15:03 mjtadema

Yes, that would be an option.

pckroon avatar Mar 04 '20 15:03 pckroon

stale PR; also it's so far behind it will probably be easier to make a new one.

fgrunewald avatar Jul 22 '22 16:07 fgrunewald