marp-vscode icon indicating copy to clipboard operation
marp-vscode copied to clipboard

Custom Marp CLI configuration support for trusted workspace

Open yhatt opened this issue 4 years ago • 5 comments

VS Code team is working now for creation trusted workspace concept: https://github.com/microsoft/vscode/issues/106488

Marp for VS Code has not allowed custom Marp CLI configuration for preview and export by default, to prevent some malicious (#85, #121). By permitting the reference to custom configuration in trusted workspace, the usage of custom configuration and engine could make safer.

Related: #121, #123

yhatt avatar Feb 06 '21 04:02 yhatt

https://code.visualstudio.com/updates/v1_56#_workspace-trust-extension-api

yhatt avatar May 05 '21 21:05 yhatt

Is there any ETA of this feature?

Serenade600 avatar May 20 '21 08:05 Serenade600

At least it requires to wait for fully adopting Workspace Trust in the stable VS Code.

yhatt avatar May 20 '21 08:05 yhatt

It seems the latest relevant PR concerning Workspace Trust is merged on July 11. So is there any ongoing effort on implementing this feature, if I may ask? I'd be more than happy to contribute on this feature, but of course not to duplicate someone else's work.

ruifengx avatar Oct 06 '21 13:10 ruifengx

Workspace trust's security model seems not fully to merge into Markdown preview yet. microsoft/vscode#131939

And we still have not decided a primary approach to extend Markdown syntax for preview and exported output. We have thought the approach of using Marp CLI config in this issue, but an another approach has suggested in marp-team/marp#176: Adopt the same mental model as existing VS Code Markdown extensions.

yhatt avatar Oct 06 '21 13:10 yhatt

Hello. Is there any activity on this?

sedyh avatar Jun 12 '23 12:06 sedyh

Close as wontfix due to the potential security issue. You still can discuss about possibility of extend the engine at marp-team/marp#176.

yhatt avatar Jun 12 '23 12:06 yhatt