FastLED_examples icon indicating copy to clipboard operation
FastLED_examples copied to clipboard

Standardize defines and file formatting

Open skypanther opened this issue 5 years ago • 2 comments

  • Updates all the files to use the same #define statements, with matching names.
  • Updates the setup() function to use a common pattern for the FastLED.addLeds() function call.
  • Updates the README with more explicit instructions for customizing and using these sample.
  • Applies common formatting (Google C style with attached brackets) to all files.

These changes should make it easier to use these samples. Novices will find a common pattern, which will be easier to follow. Experienced users will be able to more quickly use each of the samples.

Thanks for these samples! They are a great help and I refer to them often.

skypanther avatar Oct 02 '19 00:10 skypanther

@skypanther Wow Tim, I'm humbled by you taking the time to help improve all these. That's a lot of changes! I'm hoping some of those changes were automated!?

marmilicious avatar Oct 02 '19 21:10 marmilicious

Sorry that it's so large! It's mostly white space / indenting changes. My editor did that as I saved my other changes. The key change for each is really just standardizing the #defines and addLeds statements. I've manually tested many of the updated files, though sorry, not all of them.

skypanther avatar Oct 03 '19 13:10 skypanther