Zip icon indicating copy to clipboard operation
Zip copied to clipboard

Clashing Implementation with facebook/folly

Open sachinvas opened this issue 5 years ago • 0 comments

We are facing clashing implementation issue with facebook/folly (https://github.com/facebook/folly/blob/master/folly/compression/Zlib.h).

In file included from /Users/<users>/Projects/<project>/Pods/Zip/Zip/minizip/ioapi.c:17:
In file included from /Users/<users>/Projects/<project>/Pods/Zip/Zip/minizip/ioapi.h:34:
/Users/<users>/Projects/<project>/Pods/Flipper-Folly/folly/compression/Zlib.h:19:10: fatal error: 'folly/Portability.h' file not found
#include <folly/Portability.h>
         ^~~~~~~~~~~~~~~~~~~~~
1 error generated.

Please check the above logs, ioapi.h (https://github.com/marmelroy/Zip/blob/master/Zip/minizip/ioapi.h) is trying to include "zlib.h". It is resolved to "Zlib.h" from the folly.

Can you please change the import to "Zip/zlib.h"?

sachinvas avatar Dec 28 '19 12:12 sachinvas