PhoneNumberKit icon indicating copy to clipboard operation
PhoneNumberKit copied to clipboard

Bugfix - Data race + Warning

Open aiFigueiredo opened this issue 1 year ago • 0 comments

This PR aims to address #825

What was done:

  1. Added unit tests while on master to cover any possible outcomes of ParseManager.parseMultiple including a measure test.
  2. Addressed the warning by removing DispatchQueue.concurrentPerform
  3. Committed the baseline plists (set while on master writing the tests). Let me know if that shouldn't be committed.

Notes:

  1. Checked test run times and it seems this approach takes less time to complete:

Screenshot 2024-12-19 at 19 23 23 Screenshot 2024-12-19 at 19 23 34 (used the existing test as a baseline)

  1. This approach drops DispatchQueue.concurrentPerform but maybe that is not something that should be done?
  2. An alternate approach to fixing the data race could be a lock. Let me know if that is preferred.

aiFigueiredo avatar Dec 19 '24 22:12 aiFigueiredo