PhoneNumberKit
PhoneNumberKit copied to clipboard
Bugfix - Data race + Warning
This PR aims to address #825
What was done:
- Added unit tests while on
masterto cover any possible outcomes ofParseManager.parseMultipleincluding a measure test. - Addressed the warning by removing
DispatchQueue.concurrentPerform - Committed the baseline plists (set while on
masterwriting the tests). Let me know if that shouldn't be committed.
Notes:
- Checked test run times and it seems this approach takes less time to complete:
(used the existing test as a baseline)
- This approach drops
DispatchQueue.concurrentPerformbut maybe that is not something that should be done? - An alternate approach to fixing the data race could be a lock. Let me know if that is preferred.