FileBrowser icon indicating copy to clipboard operation
FileBrowser copied to clipboard

Fixed creation of tableview to allow editing

Open carlag opened this issue 6 years ago • 3 comments

Tableview was being created before the allowEditing bool was being set. So tableview could never enter edit mode.

carlag avatar Sep 03 '18 14:09 carlag

Hello, we would be interested by your PR on our fork: https://github.com/Nuglif/FileBrowser I have tried to submit my work to this repo (see PR #43 ) but with no luck.

It looks good, and behaviour is better.

lisional avatar Sep 17 '18 21:09 lisional

@lisional sure. Still kind of new to pull requests. Should I just fork https://github.com/Nuglif/FileBrowser and make a new PR?

carlag avatar Sep 22 '18 07:09 carlag

@carlag In your repository, create a new pull request but change the destination to our fork. It should be enough.

lisional avatar Sep 24 '18 19:09 lisional