react-admin icon indicating copy to clipboard operation
react-admin copied to clipboard

[RFR] add use of rest parameters in combineDataProviders

Open karpushchenko opened this issue 1 year ago • 3 comments

Closes #9675 The current implementation doesn't work with dataProvider methods with more than 2 parameters. According to documentation, the method parameter format is not strictly typed, so it is possible to add as many params as needed and then guess why combineDataProviders doesn't work

karpushchenko avatar Feb 20 '24 05:02 karpushchenko

Thanks. Could you please add unit tests?

fzaninotto avatar Feb 20 '24 07:02 fzaninotto

Thanks. Could you please add unit tests?

Yep, why not, I will update it probably tomorrow

karpushchenko avatar Feb 20 '24 07:02 karpushchenko

@fzaninotto updated with a corresponding test

karpushchenko avatar Feb 21 '24 09:02 karpushchenko

Ok, I will update it later today, not just a simple retarget of PR ( I considered it as a bugfix )

karpushchenko avatar Feb 23 '24 01:02 karpushchenko

@fzaninotto, done! Sorry for the delay

karpushchenko avatar Feb 28 '24 02:02 karpushchenko

Thanks!

fzaninotto avatar Feb 28 '24 06:02 fzaninotto