react-admin icon indicating copy to clipboard operation
react-admin copied to clipboard

Chore(ArrayField): add support for `storeKey` to manage independent selection states

Open Aijeyomah opened this issue 1 year ago • 5 comments

Problem

#10382 Describe the problem this PR solves

Solution

  • Introduced a storeKey property for ArrayField to enable distinct selection state storage for multiple instances of the same data source.
  • Added documentation and examples to demonstrate usage.

https://www.loom.com/share/b6da1650760d4a83981f602341b667e7?sid=3fa2812e-1cdc-4266-9958-89c9ff731657

Describe the solution this PR implements

How To Test

Describe the steps required to test the changes

Additional Checks

  • [x] The PR targets master for a bugfix, or next for a feature
  • [X] The PR includes unit tests (if not possible, describe why)
  • [x] The PR includes one or several stories (if not possible, describe why)
  • [x] The documentation is up to date

Also, please make sure to read the contributing guidelines.

Aijeyomah avatar Dec 01 '24 22:12 Aijeyomah

@fzaninotto Can you review? thanks

Aijeyomah avatar Dec 04 '24 00:12 Aijeyomah

Thanks for the PR! As this is a new feature, can you target the next branch? Besides, in order to test it, we'll need stories and unit tests. Can you add some, taking inspiration from the ListBase component?

djhi avatar Dec 04 '24 08:12 djhi

Thanks for the PR! As this is a new feature, can you target the next branch? Besides, in order to test it, we'll need stories and unit tests. Can you add some, taking inspiration from the ListBase component?

Yes, I can. Thanks

Aijeyomah avatar Dec 04 '24 09:12 Aijeyomah

Thanks for the PR! As this is a new feature, can you target the next branch? Besides, in order to test it, we'll need stories and unit tests. Can you add some, taking inspiration from the ListBase component?

@djhi @fzaninotto I have updated the target branch as well as written the necessary stories and tests for the feature. Please re-review. Thanks

Aijeyomah avatar Jan 02 '25 13:01 Aijeyomah

@slax57 Can you re-review? Thanks.

Aijeyomah avatar Mar 17 '25 00:03 Aijeyomah