marmelab
Reject promise in checkError with logoutUser: false and without redirectTo causes an error #10172
Add null check for redirect and When redirect is not provided, I returned false and let the called handles the redirect.
This may not be ideal solution, happy to discuss as this is my my first contribution.
Fixes #10172
Hi ,
As per understanding this issue is caused when redirect is null for some use cases they don't want to redirect but using this to display an error message.
On Mon, Sep 2, 2024, 8:58 AM Gildas Garcia @.***> wrote:
Hi, thanks for contributing. Can you please first explain the issue?
— Reply to this email directly, view it on GitHub https://github.com/marmelab/react-admin/pull/10177#issuecomment-2324823444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO463T6UPCA3YI4OJWNHX3ZURVIHAVCNFSM6AAAAABNOKDW3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUHAZDGNBUGQ . You are receiving this because you authored the thread.Message ID: @.***>
Hello @djhi, I will be glad to take the ownership of this PR if still needed, and @rktamil agree or doesn't reply at all @djhi please confirm if you want me to take this
@carloshv93 Thank you for offering to work on this issue. You can simply open a new PR, and if it gets merged first then we'll close this one. Thanks.
