ng-admin
ng-admin copied to clipboard
marmelab
#1158 allow full-row field templates in embedded view
Are you waiting for something from me on this?
From my perspective, this is ready to merge. It doesn't fix the "black magic", but it's a step in the right direction.
I haven't added any unit tests, as I feel like #1158 will be really difficult to demo in a unit test. Is that a blocker for merging this?
@RichardBradley I'll take a look at both your PR and issue this afternoon.
Ok, it's a tough one and I'm not sure that your fix is optimal.
I'll dig further on this later, but I can confirm that the embedded_list is the only field that doesn't support .template(..., true) for now.
Ok, it's a tough one and I'm not sure that your fix is optimal.
Perfect is the enemy of good :-)
It's not optimal, but it's better than what's currently there and it doesn't make anything worse. I have been using this fix in production since shortly before I posted it here. I would suggest merging it while you work on an optimal fix in parallel.
It's up to you, of course. I can continue to use a forked version with this fix applied if you don't want it in here.
Thanks for your time and hard work on ng-admin.