admin-config #57 Fix for..in bug, add tests to guard against regressions.

This fixes #57, and adds tests which a) demonstrate why this is required and b) should guard against regressions.

Dec 16 '15 10:12 RichardBradley

(This is rather ugly, but I think it is necessary. If we had "angular" in scope then a most of these could be fixed with "angular.foreach", but admin-config doesn't currently have angular as a dependency.)

Dec 16 '15 10:12 RichardBradley

I found that using "for .. of" breaks ng-admin with "ReferenceError: Symbol is not defined" errors, so I've removed that from this PR.

Dec 16 '15 17:12 RichardBradley

Any thoughts on this? This is necessary for me to use ng-admin at the same time as polyfills like Array.find

Apr 04 '16 10:04 RichardBradley

Any update on this one? I have added some tests which fail before this change and pass after it.

Do you not like the "for..in" syntax? It is ugly, but I think it is necessary, as demonstrated above. If you don't want to make this change, I understand.

Aug 25 '17 15:08 RichardBradley

Sorry about that. The PR looks fine to me expect it needs to be rebased.

Aug 25 '17 15:08 djhi

From my point of view, this is ready to merge.

I won't rebase it myself, as I am not confident that it would get merged were I to spend that time. It should be only a few minutes work to rebase & fix the conflicts if anyone with write permission wanted to do so.

May 30 '18 10:05 RichardBradley