Marlo Longley

Results 85 comments of Marlo Longley

Because https://projectmirador.org "Try a Live Demo" links there, I think.

This is now rebased. To answer the question from @taylor-steve, it looks like yes there was 1 minor change to the bundled JS after the reabse. I also tried this...

From Steve: I also think we'd want to avoid dramatically changing behavior to the point where we'd want to do a whole design review.

Another great option could be https://github.com/dbmdz/mirador-imagecropper This is developed and used by our colleagues at Leipzig, who are currently also working to make it compatible with Mirador 4.

Does this PR have implications for how other components are loading `page_location` ? They should continue to load as a helper as in: https://github.com/sul-dlss/SearchWorks/blob/b834d0f7faf48b023b8d4a2a32e8dbbdb9bf5da9/app/components/searchworks4/digital_collections_facet_header_component.rb#L5 https://github.com/sul-dlss/SearchWorks/blob/b834d0f7faf48b023b8d4a2a32e8dbbdb9bf5da9/app/components/searchworks4/search_result/collection_info_component.rb#L14