Make build_array function consider requested output file_type

Open dmitriilazukov opened this issue 5 years ago • 6 comments

Feb 09 '21 14:02 dmitriilazukov

Coverage increased (+0.003%) to 98.825% when pulling ff51fc0aca0156eb839ca1c02535b69db51a2e64 on dmitriilazukov:make-build-array-consider-file-type into 0a428b88f76c41e93eecbf49bb27b97c7b3f9de7 on rabitt:master.

Feb 09 '21 14:02 coveralls

Thanks. Could you write a unit test for this? How does this affect the behavior of pysox? Is it backwards compatible?

Feb 10 '21 08:02 lostanlen

Hi!

Could you write a unit test for this?

Done.

How does this affect the behavior of pysox?

Now build_array function works correctly. It used to ignore output file_type parameter and generate only "raw" type. Now it uses given file_type if supplied.

Is it backwards compatible?

I believe so. I did not change any core logic.

Feb 17 '21 17:02 dmitriilazukov

@lostanlen Hi, did you have a chance to review changes?

Mar 01 '21 07:03 dmitriilazukov

Thanks @dmitriilazukov. LGTM

Mar 01 '21 20:03 lostanlen

@rabitt this is ready for merging IMO

Mar 01 '21 20:03 lostanlen