jams icon indicating copy to clipboard operation
jams copied to clipboard

Migrate deprecated imp package to importlib

Open robaerd opened this issue 2 years ago • 3 comments

This PR fixes #214 by migrating from imp to importlib.

robaerd avatar Nov 01 '23 20:11 robaerd

Thanks for this, and sorry for the slow response. I'll merge this after we fix the CI to run on github actions so we can verify that it behaves correctly.

bmcfee avatar Nov 22 '23 15:11 bmcfee

Just FYI, without this PR mirdata cannot be used with versions of python 3.11 or later

hyve9 avatar Mar 24 '24 02:03 hyve9

Just noting that I'll try to get this squared away this week. There are some blockers upstream that also needed to be updated (eg mir_eval) before this makes sense to do, but the work is mostly done at this point.

bmcfee avatar Mar 25 '24 16:03 bmcfee

Sorry, this got away from me :facepalm:

The mir_eval reelase is still blocking CI updates, but this PR is okay for the time being. Bigger picture, we can actually do away with this importlib stuff entirely by modernizing the packaging info to use setup.cfg and pull version from attributes, rather than doing import hackery. But I can take that into a separate PR.

bmcfee avatar Dec 06 '24 14:12 bmcfee