jams icon indicating copy to clipboard operation
jams copied to clipboard

sed_eval bindings?

Open bmcfee opened this issue 6 years ago • 6 comments

[Tagging @justinsalamon ]

The jams.eval module provides a unified interface between jams annotations and mir_eval metrics. Would it be possible to add bindings to sed_eval as well, for evaluating tag_* annotations? I haven't used sed_eval directly, but this seems like it would be useful for handling things like instrument detection.

bmcfee avatar Feb 22 '18 15:02 bmcfee

I think this could be of interest, not only for mir tasks (e.g. instrument ID) but also directly for environmental sound eval via JAMS files.

A possible complication however is that if I remember correctly the sed_eval paradigm is that given a collection of recordings for evaluation (a test set), intermediate metrics are aggregated from all files before computing the final set of metrics. This might be a little tricky to support given the current collection-agnostic paradigm JAMS follows?

justinsalamon avatar Feb 22 '18 19:02 justinsalamon

I would just simplify that to a collection of 1 for each call to eval.tag. Does that seem reasonable?

bmcfee avatar Feb 22 '18 19:02 bmcfee

Yes and no. Yes in that it allows you to get per-file scores. No in that averaging per-file scores will give you a different result compared to computing per-file intermediate stats and then a final set of metrics, where the latter is what the sed_eval folks (and consequently DCASE) are advocating for. By only supporting per-file metrics, we might encourage someone to do the former, which would give them eval results that are inconsistent with what's expected in the literature (or what will eventually be expected once the dust settles on SED).

justinsalamon avatar Feb 22 '18 19:02 justinsalamon

Well, I've never liked the collection-wise error reporting, but you could handle it gracefully by accepting a sed_eval object as an optional parameter. If none is provided, one is constructed. That way, you can get track-wise metrics easily, and collection-wise metrics with a bit more work.

bmcfee avatar Feb 22 '18 19:02 bmcfee

That sounds like a reasonable solution to me

justinsalamon avatar Feb 22 '18 19:02 justinsalamon

(Delayed update)

This one is stalled for a couple of reasons relating to the sed_eval dependency chain.

bmcfee avatar Apr 13 '18 18:04 bmcfee