markvincze
link back to repo is off by one line
When I click on the hyperlink to the .proto file in the repo for a message, the highlighted line "#L166" is off by one -- it's selecting the line above the message definition instead of the line that actually starts with message.
This seems like a very petty thing, but in fact (forgetting how that particular browser window got opened) I was confused later at why one of the lines of code was highlighted. Especially since it was a line of just comments.
My repository-type = "github" and I don't think any other details are pertinent, other than that I'm using the version from the main branch.
@gmabey I made an attempt at fixing this, the GitHub line numbers were always off by one.
Can you check if it is working now correctly in version 0.18.966?
Hi Mark, Realistically, I’m not going to get around to testing your fix in the near future. I will likely return to this part of our development in three weeks, and I will plan on testing it then.
On Tue, Sep 2, 2025 at 9:05 AM Mark Vincze @.***> wrote:
markvincze left a comment (markvincze/sabledocs#74) https://github.com/markvincze/sabledocs/issues/74#issuecomment-3245739838
@gmabey https://github.com/gmabey I made an attempt at fixing this, the GitHub line numbers were always off by one. Can you check if it is working now correctly in version 0.18.966?
— Reply to this email directly, view it on GitHub https://github.com/markvincze/sabledocs/issues/74#issuecomment-3245739838, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVTOUFVJNTL7YLG2BC2NYT3QWW5BAVCNFSM6AAAAABRKBUCFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBVG4ZTSOBTHA . You are receiving this because you were mentioned.Message ID: @.***>