Markus Scherer

Results 324 comments of Markus Scherer

CLDR-18815 Khmer person name tests: adjust for Unicode 17 GCB changes

Hi @eggrobin / @richgillam / @echeran: - I need to fix at least some of the commit messages, to pass the required check. - I am thinking to partially rebase...

> > It would probably be a good idea to make utfStringCodePoints a range adaptor object rather than a function… > > Ah, we can only do that in C++23....

@eggrobin might we be done here? I am running out of reasonable TODOs.

By the way, I think we should squash the commits here between reviewer approval and merging. The many little bug fix commits don't seem worth preserving.

@richgillam or @roubert could either of you give at least a cursory look at this PR? This is to make the new code point iterators work with C++20-style code unit...

> [0f63cd5](https://github.com/unicode-org/icu/commit/0f63cd5f9d81e21e92a06b3b8f91a4d320d330a7) probably wants to be its own PR, too merged: - https://github.com/unicode-org/icu/pull/3525

> > [0f63cd5](https://github.com/unicode-org/icu/commit/0f63cd5f9d81e21e92a06b3b8f91a4d320d330a7) probably wants to be its own PR, too > > merged: > > * [ICU-23054 Make the MSVC stdcpplatest build work as intended #3525](https://github.com/unicode-org/icu/pull/3525) @eggrobin can you...

Fuzzing does not seem right for this. What I do in ICU unit tests is that every time I expect compare(s1, s2) to return some value, I use a test...