BinaryEye icon indicating copy to clipboard operation
BinaryEye copied to clipboard

Changing engine for decoding codes

Open ghost opened this issue 6 years ago • 3 comments

Regarding - https://github.com/markusfisch/BinaryEye/issues/49

I found nice performant engine for decoding QR Codes.

It's BoofCV

Performance test compared to others, like:

  • BoofCV (Ver. 0.33)
  • OpenCV (Ver. 4.0.1)
  • Quirc (Feb 1, 2018. SHA 307473db)
  • ZBar (Ver. 0.10)
  • ZXing (Ver. 3.3.3)

looks really impressive

Source:

  • https://boofcv.org/index.php?title=Performance:QrCode
  • https://boofcv.org/index.php?title=Performance:OpenCV:BoofCV

What do you think about changing engine to BoofCV? Of course if it has same features and supports same codes. Just FYI issue.

ghost avatar Jul 24 '19 20:07 ghost

This looks very interesting indeed! Will definitely try it out! 👍

As far as I can see, BoofCV would only decode QR codes, right? It wouldn't be much of a problem to run the camera image through another barcode scanner. Especially if it's really fast.

markusfisch avatar Jul 24 '19 20:07 markusfisch

I don't know, I'm not specialist in this matter. I just only found about this when I was searching what could be the cause of https://github.com/markusfisch/BinaryEye/issues/49 and encounter that WallΞTH is changing engine for decoding codes from ZXing to BoofCV in https://github.com/walleth/walleth/issues/383 because of the same issue https://github.com/walleth/walleth/issues/382.

ghost avatar Jul 24 '19 21:07 ghost

Well, it's always good to have options.

I think it's pretty silly for ZXing to require minSdkVersion 24 for version 3.4.0. It's far too early for this and I won't exclude users just because they want to use fancy stuff.

Never trade compatibility for developer comfort. Nobody cares how an app is written. People just care if it works or not.

markusfisch avatar Jul 25 '19 09:07 markusfisch