markus-jehl

Is this still an issue?

If you don't mind, I'll change this as part of https://github.com/UCL/STIR/pull/1291 where I'm already changing various things in the scatter estimation.

original scatter:  below are plots of the differences between downsampled scatter and original scatter, relative to mean(abs(original_scatter))=11.5 downsampling factor 1.066667 (from 32 to 30 detectors per module)  downsampling...

 relative difference between original scatter and downsampled scatter with factor 2 (divided by mean intensity of areas with intensity > 0.1 => 0.5) 

Therefore it looks like choosing integer factors for the downsampling isn't required, and the intersections between the modules remain problematic (sometimes over 10% errors in the scatter estimate). However, on...

As part of this investigation, a bug was found: https://github.com/UCL/STIR/issues/1396 This should be fixed on the ProjData side, but it raises another problem with the scatter estimation code itself: for...

> I'm hoping that once this is done, we can avoid the almost repeated code for the blocks and cylindrical case, but maybe do that in stages. Do you mean...

On a simulated cylinder, the scatter estimation has much smaller errors when we use linear interpolation instead of quadratic interpolation. I strongly suspect that this is because we quite aggressively...

Thanks! I will have a look

Does building SWIG work for you? I get some errors, e.g.: ``` In file included from /workspace/python-reconstruction-pipeline/libs/build/stir/Stir-prefix/src/Stir-build/src/swig/CMakeFiles/_stir.dir/stirPYTHON_wrap.cxx:3964: In file included from /workspace/python-reconstruction-pipeline/libs/build/stir/Stir-prefix/src/Stir/src/include/stir/ProjDataInfoBlocksOnCylindricalNoArcCorr.h:27: In file included from /workspace/python-reconstruction-pipeline/libs/build/stir/Stir-prefix/src/Stir/src/include/stir/ProjDataInfoGenericNoArcCorr.h:27: In file included...